Shiloh/brotherton-erpnext
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(HR): Ignore invalid fields when updating employee details (#27456)

Browse Source
This commit is contained in:
Chillar Anand 2021-09-14 12:00:34 +05:30 committed by GitHub
parent 1c1b476d67
commit 95460d9818
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/hr/utils.py
View File

@ -32,7 +32,10 @@ def set_employee_name(doc):
def update_employee(employee, details, date=None, cancel=False): def update_employee(employee, details, date=None, cancel=False):
internal_work_history = {} internal_work_history = {}
for item in details: for item in details:
fieldtype = frappe.get_meta("Employee").get_field(item.fieldname).fieldtype field = frappe.get_meta("Employee").get_field(item.fieldname)
if not field:
continue
fieldtype = field.fieldtype
new_data = item.new if not cancel else item.current new_data = item.new if not cancel else item.current
if fieldtype == "Date" and new_data: if fieldtype == "Date" and new_data:
new_data = getdate(new_data) new_data = getdate(new_data)