From 94719e7e818dd6f5ae6b1fc02a32812bee443a02 Mon Sep 17 00:00:00 2001 From: Anurag Mishra Date: Mon, 4 May 2020 18:16:47 +0530 Subject: [PATCH] fix: tests --- .../hr/doctype/additional_salary/additional_salary.json | 2 +- .../hr/doctype/leave_encashment/test_leave_encashment.py | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/erpnext/hr/doctype/additional_salary/additional_salary.json b/erpnext/hr/doctype/additional_salary/additional_salary.json index bf9d8192d0..bfb543f49a 100644 --- a/erpnext/hr/doctype/additional_salary/additional_salary.json +++ b/erpnext/hr/doctype/additional_salary/additional_salary.json @@ -163,7 +163,7 @@ ], "is_submittable": 1, "links": [], - "modified": "2020-03-02 18:06:29.170878", + "modified": "2020-04-04 18:06:29.170878", "modified_by": "Administrator", "module": "HR", "name": "Additional Salary", diff --git a/erpnext/hr/doctype/leave_encashment/test_leave_encashment.py b/erpnext/hr/doctype/leave_encashment/test_leave_encashment.py index e5bd170bc4..2819e1673c 100644 --- a/erpnext/hr/doctype/leave_encashment/test_leave_encashment.py +++ b/erpnext/hr/doctype/leave_encashment/test_leave_encashment.py @@ -53,7 +53,10 @@ class TestLeaveEncashment(unittest.TestCase): self.assertEqual(leave_encashment.encashment_amount, 250) leave_encashment.submit() - self.assertTrue(frappe.db.get_value("Leave Encashment", leave_encashment.name, "additional_salary")) + + # assert links + add_sal = frappe.get_all("Additional salary", filters = {"ref_docname": leave_encashment.name})[0] + self.assertTrue(add_sal) def test_creation_of_leave_ledger_entry_on_submit(self): frappe.db.sql('''delete from `tabLeave Encashment`''') @@ -75,5 +78,8 @@ class TestLeaveEncashment(unittest.TestCase): self.assertEquals(leave_ledger_entry[0].leaves, leave_encashment.encashable_days * -1) # check if leave ledger entry is deleted on cancellation + + frappe.db.sql("Delete from `tabAdditional Salary` WHERE ref_docname = %s", (leave_encashment.name) ) + leave_encashment.cancel() self.assertFalse(frappe.db.exists("Leave Ledger Entry", {'transaction_name':leave_encashment.name}))