From 93b1072cbad3577a7b5d7023e5b06ced01b74da4 Mon Sep 17 00:00:00 2001 From: Valmik Jangla Date: Tue, 16 Feb 2016 14:47:05 +0530 Subject: [PATCH] Improved code --- .../hr/doctype/offer_letter/offer_letter.js | 24 ++++++++++++------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/erpnext/hr/doctype/offer_letter/offer_letter.js b/erpnext/hr/doctype/offer_letter/offer_letter.js index 552a9f0313..526833a4ce 100755 --- a/erpnext/hr/doctype/offer_letter/offer_letter.js +++ b/erpnext/hr/doctype/offer_letter/offer_letter.js @@ -1,6 +1,8 @@ // Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors // License: GNU General Public License v3. See license.txt +frappe.provide("erpnext.offer_letter"); + frappe.ui.form.on("Offer Letter", { select_terms: function(frm) { frappe.model.get_value("Terms and Conditions", frm.doc.select_terms, "terms", function(value) { @@ -10,16 +12,20 @@ frappe.ui.form.on("Offer Letter", { refresh:function(frm){ if((!frm.doc.__islocal) && (frm.doc.status=='Accepted') && (frm.doc.docstatus===1)){ - frm.add_custom_button(__('Make Employee'), - frm.cscript['Make Employee']); - } -} + frm.add_custom_button(__('Make Employee'), + function() { + erpnext.offer_letter.make_employee(frm) + } + ); + } + } + }); -cur_frm.cscript['Make Employee'] = function() { -frappe.model.open_mapped_doc({ - method: "erpnext.hr.doctype.employee.employee.make_employee", - frm : cur_frm -}); +erpnext.offer_letter.make_employee = function(frm) { + frappe.model.open_mapped_doc({ + method: "erpnext.hr.doctype.employee.employee.make_employee", + frm : frm + }); } \ No newline at end of file