From 938f7d2266bde259c40c889014a0139c31e3138f Mon Sep 17 00:00:00 2001 From: barredterra <14891507+barredterra@users.noreply.github.com> Date: Fri, 17 Sep 2021 11:58:24 +0200 Subject: [PATCH] reafctor: validate instead of postprocess --- erpnext/accounts/doctype/sales_invoice/sales_invoice.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py index 0aa6eab862..f240fe9b19 100644 --- a/erpnext/accounts/doctype/sales_invoice/sales_invoice.py +++ b/erpnext/accounts/doctype/sales_invoice/sales_invoice.py @@ -2533,8 +2533,7 @@ def create_dunning(source_name, target_doc=None, ignore_permissions=False): target.closing_text = letter_text.get('closing_text') target.language = letter_text.get('language') - def postprocess_overdue_payment(source, target, source_parent): - target.overdue_days = (getdate(nowdate()) - getdate(source.due_date)).days + target.validate() return get_mapped_doc( from_doctype="Sales Invoice", @@ -2553,8 +2552,7 @@ def create_dunning(source_name, target_doc=None, ignore_permissions=False): "name": "payment_schedule", "parent": "sales_invoice" }, - "condition": lambda doc: doc.outstanding > 0, - "postprocess": postprocess_overdue_payment + "condition": lambda doc: doc.outstanding > 0 } }, target_doc=target_doc,