Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: not checking all fields

Browse Source 
`break` will break out of the loop without checking remaining fields.
This commit is contained in:
Ankush Menat 2021-05-22 23:06:16 +05:30
parent 83e6e2e68a
commit 931c886f92
No known key found for this signature in database
GPG Key ID: 8EA82E09BBD13AAF
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/stock/doctype/item/item.py
View File

@ -965,9 +965,7 @@ class Item(WebsiteGenerator):
if values: if values:
for field in fields: for field in fields:
if cstr(self.get(field)) != cstr(values.get(field)): if cstr(self.get(field)) != cstr(values.get(field)):
if not self.check_if_linked_document_exists(field): if self.check_if_linked_document_exists(field):
break # no linked document, allowed
else:
frappe.throw(_("As there are existing transactions against item {0}, you can not change the value of {1}").format(self.name, frappe.bold(self.meta.get_label(field)))) frappe.throw(_("As there are existing transactions against item {0}, you can not change the value of {1}").format(self.name, frappe.bold(self.meta.get_label(field))))
def check_if_linked_document_exists(self, field): def check_if_linked_document_exists(self, field):