Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: validate Packing Slip Item Qty with DN Items

Browse Source
This commit is contained in:
s-aga-r 2023-04-28 17:05:51 +05:30
parent 9e5b102768
commit 90701c7ae9
1 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
erpnext/stock/doctype/packing_slip/packing_slip.py
View File

@ -38,7 +38,7 @@ class PackingSlip(StatusUpdater):
self.validate_delivery_note()
self.validate_case_nos()
self.validate_mandatory()
self.validate_items()
validate_uom_is_integer(self, "stock_uom", "qty")
validate_uom_is_integer(self, "weight_uom", "net_weight")
@ -91,13 +91,38 @@ class PackingSlip(StatusUpdater):
)
)
def validate_mandatory(self):
def validate_items(self):
for item in self.items:
if not item.dn_detail and not item.pi_detail:
frappe.throw(
_("Row {0}: Either Delivery Note Item or Packed Item reference is mandatory").format(item.idx)
)
remaining_qty = frappe.db.get_value(
"Delivery Note Item" if item.dn_detail else "Packed Item",
{"name": item.dn_detail or item.pi_detail, "docstatus": 0},
["sum(qty - packed_qty)"],
)
if remaining_qty is None:
frappe.throw(
_("Row {0}: Please provide a valid Delivery Note Item or Packed Item reference.").format(
item.idx
)
)
elif remaining_qty <= 0:
frappe.throw(
_("Row {0}: Packing Slip is already created for Item {1}.").format(
item.idx, frappe.bold(item.item_code)
)
)
elif item.qty > remaining_qty:
frappe.throw(
_("Row {0}: Qty cannot be greater than {1} for the Item {2}.").format(
item.idx, frappe.bold(remaining_qty), frappe.bold(item.item_code)
)
)
def set_missing_values(self):
if not self.from_case_no:
self.from_case_no = self.get_recommended_case_no()