Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Handling if no default dimension exists

Browse Source
This commit is contained in:
deepeshgarg007 2019-08-16 14:00:26 +05:30
parent 2fb6bc9867
commit 8d0b6f9a60
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
erpnext/public/js/utils/dimension_tree_filter.js
View File

@ -28,25 +28,27 @@ erpnext.doctypes_with_dimensions.forEach((doctype) => {
}); });
} }
if (frappe.meta.has_field(doctype, dimension['fieldname'])) { if (Object.keys(erpnext.default_dimensions).length > 0) {
if (frm.is_new() && frappe.meta.has_field(doctype, 'company') && frm.doc.company) { if (frappe.meta.has_field(doctype, dimension['fieldname'])) {
frm.set_value(dimension['fieldname'], erpnext.default_dimensions[frm.doc.company][dimension['document_type']]); if (frm.is_new() && frappe.meta.has_field(doctype, 'company') && frm.doc.company) {
frm.set_value(dimension['fieldname'], erpnext.default_dimensions[frm.doc.company][dimension['document_type']]);
}
} }
}
if (frm.doc.items && frm.doc.items.length) { if (frm.doc.items && frm.doc.items.length) {
frm.doc.items[0][dimension['fieldname']] = erpnext.default_dimensions[frm.doc.company][dimension['document_type']]; frm.doc.items[0][dimension['fieldname']] = erpnext.default_dimensions[frm.doc.company][dimension['document_type']];
} }
if (frm.doc.accounts && frm.doc.accounts.length) { if (frm.doc.accounts && frm.doc.accounts.length) {
frm.doc.accounts[0][dimension['fieldname']] = erpnext.default_dimensions[frm.doc.company][dimension['document_type']]; frm.doc.accounts[0][dimension['fieldname']] = erpnext.default_dimensions[frm.doc.company][dimension['document_type']];
}
} }
}); });
}); });
}, },
company: function(frm) { company: function(frm) {
if(frm.doc.company) { if(frm.doc.company && (Object.keys(erpnext.default_dimensions).length > 0)) {
erpnext.dimension_filters.forEach((dimension) => { erpnext.dimension_filters.forEach((dimension) => {
if (frappe.meta.has_field(doctype, dimension['fieldname'])) { if (frappe.meta.has_field(doctype, dimension['fieldname'])) {
frm.set_value(dimension['fieldname'], erpnext.default_dimensions[frm.doc.company][dimension['document_type']]); frm.set_value(dimension['fieldname'], erpnext.default_dimensions[frm.doc.company][dimension['document_type']]);