Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #23022 from marination/loan-amount

Browse Source 
fix: Validate or Set Loan Amount first
This commit is contained in:
Deepesh Garg 2020-08-13 19:53:09 +05:30 committed by GitHub
commit 8ca57eb5dd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
erpnext/loan_management/doctype/loan_application/loan_application.py
View File

@ -16,14 +16,16 @@ from six import string_types
class LoanApplication(Document): class LoanApplication(Document):
def validate(self): def validate(self):
validate_repayment_method(self.repayment_method, self.loan_amount, self.repayment_amount,
self.repayment_periods, self.is_term_loan)
self.validate_loan_type()
self.set_pledge_amount() self.set_pledge_amount()
self.set_loan_amount() self.set_loan_amount()
self.validate_loan_amount() self.validate_loan_amount()
if self.is_term_loan:
validate_repayment_method(self.repayment_method, self.loan_amount, self.repayment_amount,
self.repayment_periods, self.is_term_loan)
self.validate_loan_type()
self.get_repayment_details() self.get_repayment_details()
self.check_sanctioned_amount_limit() self.check_sanctioned_amount_limit()
@ -106,7 +108,7 @@ class LoanApplication(Document):
if self.is_secured_loan and self.proposed_pledges: if self.is_secured_loan and self.proposed_pledges:
self.maximum_loan_amount = 0 self.maximum_loan_amount = 0
for security in self.proposed_pledges: for security in self.proposed_pledges:
self.maximum_loan_amount += security.post_haircut_amount self.maximum_loan_amount += flt(security.post_haircut_amount)
if not self.loan_amount and self.is_secured_loan and self.proposed_pledges: if not self.loan_amount and self.is_secured_loan and self.proposed_pledges:
self.loan_amount = self.maximum_loan_amount self.loan_amount = self.maximum_loan_amount