Merge pull request #25261 from ankush/issue_status_banner_fix

fix: condition for SLA status banner
This commit is contained in:
Deepesh Garg 2021-04-10 17:56:51 +05:30 committed by GitHub
commit 8a01dbe8e1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -49,8 +49,10 @@ frappe.ui.form.on("Issue", {
},
refresh: function(frm) {
if (frm.doc.status !== "Closed") {
if (frm.doc.service_level_agreement && frm.doc.agreement_status === "Ongoing") {
// alert messages
if (frm.doc.status !== "Closed" && frm.doc.service_level_agreement
&& frm.doc.agreement_status === "Ongoing") {
frappe.call({
"method": "frappe.client.get",
args: {
@ -78,22 +80,7 @@ frappe.ui.form.on("Issue", {
}
}
});
}
frm.add_custom_button(__("Close"), function () {
frm.set_value("status", "Closed");
frm.save();
});
frm.add_custom_button(__("Task"), function () {
frappe.model.open_mapped_doc({
method: "erpnext.support.doctype.issue.issue.make_task",
frm: frm
});
}, __("Create"));
} else {
if (frm.doc.service_level_agreement) {
} else if (frm.doc.service_level_agreement) {
frm.dashboard.clear_headline();
let agreement_status = (frm.doc.agreement_status == "Fulfilled") ?
@ -109,6 +96,21 @@ frappe.ui.form.on("Issue", {
);
}
// buttons
if (frm.doc.status !== "Closed") {
frm.add_custom_button(__("Close"), function() {
frm.set_value("status", "Closed");
frm.save();
});
frm.add_custom_button(__("Task"), function() {
frappe.model.open_mapped_doc({
method: "erpnext.support.doctype.issue.issue.make_task",
frm: frm
});
}, __("Create"));
} else {
frm.add_custom_button(__("Reopen"), function() {
frm.set_value("status", "Open");
frm.save();