From 2f09dc0e62e8c1008d7cc0f956ebf38c4e7df20c Mon Sep 17 00:00:00 2001 From: Rohit Waghchaure Date: Fri, 10 Feb 2017 12:44:04 +0530 Subject: [PATCH 1/2] [Fix] Valuation method changing issue in the item --- erpnext/stock/doctype/item/item.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/erpnext/stock/doctype/item/item.py b/erpnext/stock/doctype/item/item.py index 53faa43f24..ad1407a3de 100644 --- a/erpnext/stock/doctype/item/item.py +++ b/erpnext/stock/doctype/item/item.py @@ -451,6 +451,8 @@ class Item(WebsiteGenerator): "valuation_method", "has_batch_no", "is_fixed_asset") vals = frappe.db.get_value("Item", self.name, to_check, as_dict=True) + if not vals.get('valuation_method'): + vals['valuation_method'] = frappe.db.get_single_value("Stock Settings", "valuation_method") or "FIFO" if vals: for key in to_check: From bdd470a6d13eefbf8c993ddea75f6e2417407632 Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Fri, 10 Feb 2017 17:12:48 +0530 Subject: [PATCH 2/2] Update item.py --- erpnext/stock/doctype/item/item.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/stock/doctype/item/item.py b/erpnext/stock/doctype/item/item.py index ad1407a3de..4d5265f72a 100644 --- a/erpnext/stock/doctype/item/item.py +++ b/erpnext/stock/doctype/item/item.py @@ -451,7 +451,7 @@ class Item(WebsiteGenerator): "valuation_method", "has_batch_no", "is_fixed_asset") vals = frappe.db.get_value("Item", self.name, to_check, as_dict=True) - if not vals.get('valuation_method'): + if not vals.get('valuation_method') and self.get('valuation_method'): vals['valuation_method'] = frappe.db.get_single_value("Stock Settings", "valuation_method") or "FIFO" if vals: