Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: set avg response time only when there are responses

Browse Source
This commit is contained in:
Rucha Mahabal 2020-05-06 13:37:10 +05:30
parent 3d891f8e89
commit 8993d38daf
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/support/doctype/issue/issue.py
View File

@ -322,14 +322,14 @@ def set_average_response_time(issue):
if len(communications): if len(communications):
response_times = [] response_times = []
for i in range(len(communications)-1): for i in range(len(communications)):
if communications[i].sent_or_received == "Sent" and communications[i-1].sent_or_received == "Received": if communications[i].sent_or_received == "Sent" and communications[i-1].sent_or_received == "Received":
response_time = time_diff_in_seconds(communications[i].creation, communications[i-1].creation) response_time = time_diff_in_seconds(communications[i].creation, communications[i-1].creation)
if response_time > 0: if response_time > 0:
response_times.append(response_time) response_times.append(response_time)
if response_times:
avg_response_time = sum(response_times) / len(response_times) avg_response_time = sum(response_times) / len(response_times)
issue.db_set('avg_response_time', avg_response_time) issue.db_set('avg_response_time', avg_response_time)
def set_resolution_time(issue): def set_resolution_time(issue):
@ -349,7 +349,7 @@ def set_user_resolution_time(issue):
) )
pending_time = [] pending_time = []
for i in range(len(communications)-1): for i in range(len(communications)):
if communications[i].sent_or_received == "Received" and communications[i-1].sent_or_received == "Sent": if communications[i].sent_or_received == "Received" and communications[i-1].sent_or_received == "Sent":
wait_time = time_diff_in_seconds(communications[i].creation, communications[i-1].creation) wait_time = time_diff_in_seconds(communications[i].creation, communications[i-1].creation)
if wait_time > 0: if wait_time > 0: