Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: escape sql filters in credit report

Browse Source 
closes #24965
This commit is contained in:
Ankush Menat 2021-04-03 12:28:34 +05:30
parent 679177f9e0
commit 87b2a51322
No known key found for this signature in database
GPG Key ID: 8EA82E09BBD13AAF
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/selling/report/customer_credit_balance/customer_credit_balance.py
View File

@ -57,18 +57,18 @@ def get_columns(customer_naming_type):
return columns return columns
def get_details(filters): def get_details(filters):
conditions = ""
if filters.get("customer"): sql_query = """SELECT
conditions += " AND c.name = '" + filters.get("customer") + "'"
return frappe.db.sql("""SELECT
c.name, c.customer_name, c.name, c.customer_name,
ccl.bypass_credit_limit_check, ccl.bypass_credit_limit_check,
c.is_frozen, c.disabled c.is_frozen, c.disabled
FROM `tabCustomer` c, `tabCustomer Credit Limit` ccl FROM `tabCustomer` c, `tabCustomer Credit Limit` ccl
WHERE WHERE
c.name = ccl.parent c.name = ccl.parent
AND ccl.company = '{0}' AND ccl.company = %(company)s"""
{1}
""".format( filters.get("company"),conditions), as_dict=1) #nosec # customer filter is optional.
if filters.get("customer"):
sql_query += " AND c.name = %(customer)s"
return frappe.db.sql(sql_query, filters, as_dict=1)