From 8712ac6d39246425a7e95130cbeec369101bc87c Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Thu, 23 Jul 2020 18:09:35 +0530 Subject: [PATCH] fix: Job offer is mandatory for employee onboarding (#22791) --- .../doctype/employee_onboarding/test_employee_onboarding.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/erpnext/hr/doctype/employee_onboarding/test_employee_onboarding.py b/erpnext/hr/doctype/employee_onboarding/test_employee_onboarding.py index 35c9f728b6..4e9ee3b143 100644 --- a/erpnext/hr/doctype/employee_onboarding/test_employee_onboarding.py +++ b/erpnext/hr/doctype/employee_onboarding/test_employee_onboarding.py @@ -8,6 +8,7 @@ import unittest from frappe.utils import nowdate from erpnext.hr.doctype.employee_onboarding.employee_onboarding import make_employee from erpnext.hr.doctype.employee_onboarding.employee_onboarding import IncompleteTaskError +from erpnext.hr.doctype.job_offer.test_job_offer import create_job_offer class TestEmployeeOnboarding(unittest.TestCase): def test_employee_onboarding_incomplete_task(self): @@ -15,8 +16,13 @@ class TestEmployeeOnboarding(unittest.TestCase): frappe.delete_doc('Employee Onboarding', {'employee_name': 'Test Researcher'}) _set_up() applicant = get_job_applicant() + + job_offer = create_job_offer(job_applicant=applicant.name) + job_offer.submit() + onboarding = frappe.new_doc('Employee Onboarding') onboarding.job_applicant = applicant.name + onboarding.job_offer = job_offer.name onboarding.company = '_Test Company' onboarding.designation = 'Researcher' onboarding.append('activities', {