Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Validate LCV for Invoices without Update Stock

Browse Source
This commit is contained in:
marination 2021-07-05 14:24:38 +05:30
parent 6949114569
commit 86f5dfbb8f
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
erpnext/stock/doctype/landed_cost_voucher/landed_cost_voucher.py
View File

@ -60,8 +60,19 @@ class LandedCostVoucher(Document):
receipt_documents = [] receipt_documents = []
for d in self.get("purchase_receipts"): for d in self.get("purchase_receipts"):
if frappe.db.get_value(d.receipt_document_type, d.receipt_document, "docstatus") != 1: doc_data = frappe.db.get_values(
frappe.throw(_("Receipt document must be submitted")) d.receipt_document_type,
d.receipt_document,
["docstatus", "update_stock"],
as_dict=1
)[0]
if doc_data.get("docstatus") != 1:
msg = f"Row {d.idx}: Receipt Document {frappe.bold(d.receipt_document)} must be submitted"
frappe.throw(_(msg), title=_("Invalid Document"))
elif d.receipt_document_type == "Purchase Invoice" and not doc_data.get("update_stock"):
msg = _(f"Row {d.idx}: Purchase Invoice {frappe.bold(d.receipt_document)} has no stock impact.")
msg += "<br>" + _("Please create Landed Cost Vouchers against Invoices with 'Update Stock' enabled.")
frappe.throw(msg, title=_("Incorrect Invoice"))
else: else:
receipt_documents.append(d.receipt_document) receipt_documents.append(d.receipt_document)