Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: silent test failure in stock assertions (#31377)

Browse Source 
If actual values are not present then test is silently passing, # of
actual values should be at least equal to expected values.
This commit is contained in:
Ankush Menat 2022-06-15 21:19:09 +05:30 committed by GitHub
parent 5c6f22f275
commit 86919d2a6d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/accounts/utils.py
View File

@ -1175,7 +1175,9 @@ def repost_gle_for_stock_vouchers(
voucher_obj.make_gl_entries(gl_entries=expected_gle, from_repost=True) voucher_obj.make_gl_entries(gl_entries=expected_gle, from_repost=True)
else: else:
_delete_gl_entries(voucher_type, voucher_no) _delete_gl_entries(voucher_type, voucher_no)
frappe.db.commit()
if not frappe.flags.in_test:
frappe.db.commit()
if repost_doc: if repost_doc:
repost_doc.db_set( repost_doc.db_set(

3
erpnext/stock/tests/test_utils.py
View File

@ -26,6 +26,7 @@ class StockTestMixin:
filters=filters, filters=filters,
order_by="timestamp(posting_date, posting_time), creation", order_by="timestamp(posting_date, posting_time), creation",
) )
self.assertGreaterEqual(len(sles), len(expected_sles))
for exp_sle, act_sle in zip(expected_sles, sles): for exp_sle, act_sle in zip(expected_sles, sles):
for k, v in exp_sle.items(): for k, v in exp_sle.items():
@ -49,7 +50,7 @@ class StockTestMixin:
filters=filters, filters=filters,
order_by=order_by or "posting_date, creation", order_by=order_by or "posting_date, creation",
) )
self.assertGreaterEqual(len(actual_gles), len(expected_gles))
for exp_gle, act_gle in zip(expected_gles, actual_gles): for exp_gle, act_gle in zip(expected_gles, actual_gles):
for k, exp_value in exp_gle.items(): for k, exp_value in exp_gle.items():
act_value = act_gle[k] act_value = act_gle[k]