From 8675ca5bdd838460d56be8eadf6790cadc605ba3 Mon Sep 17 00:00:00 2001 From: Subin Tom Date: Wed, 29 Sep 2021 11:11:55 +0530 Subject: [PATCH] fix: using db.exists and get_value instead of get_doc --- .../doctype/taxjar_settings/taxjar_settings.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.py b/erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.py index 408278342b..dd83c174aa 100644 --- a/erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.py +++ b/erpnext/erpnext_integrations/doctype/taxjar_settings/taxjar_settings.py @@ -25,9 +25,9 @@ class TaxJarSettings(Document): custom_fields = [] for dt in ['Item', 'Sales Invoice Item']: - doc = frappe.get_doc('Custom Field', {'dt': dt, 'fieldname':'product_tax_category'}) + doc = frappe.db.exists('Custom Field', {'dt': dt, 'fieldname':'product_tax_category'}) custom_fields.append(doc) - fields_hidden = doc.get('hidden') if doc else 0 + fields_hidden = frappe.db.get_value('Custom Field', {'dt': dt, 'fieldname':'product_tax_category'},'hidden') fields_already_exist = True if custom_fields else False