From 458fda8ca59df4a72e1161bc674b327ac9a8026c Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Wed, 3 Apr 2013 13:30:17 +0530 Subject: [PATCH 1/2] [quotation] [fix] letter head --- selling/doctype/quotation/quotation.txt | 64 +++---------------------- 1 file changed, 6 insertions(+), 58 deletions(-) diff --git a/selling/doctype/quotation/quotation.txt b/selling/doctype/quotation/quotation.txt index 23e767c328..feda14c591 100644 --- a/selling/doctype/quotation/quotation.txt +++ b/selling/doctype/quotation/quotation.txt @@ -1,8 +1,8 @@ [ { - "creation": "2013-04-03 09:50:56", + "creation": "2013-04-03 09:10:44", "docstatus": 0, - "modified": "2013-04-03 09:53:04", + "modified": "2013-04-03 09:58:02", "modified_by": "Administrator", "owner": "Administrator" }, @@ -34,7 +34,9 @@ "parent": "Quotation", "parentfield": "permissions", "parenttype": "DocType", - "read": 1 + "permlevel": 0, + "read": 1, + "report": 1 }, { "doctype": "DocType", @@ -678,7 +680,7 @@ "label": "Letter Head", "oldfieldname": "letter_head", "oldfieldtype": "Select", - "options": "\nDefault\nERP Grey Large\nERP LOGO\nERPNext Logo Black\nERPNext WT Logo", + "options": "link:Letter Head", "print_hide": 1, "read_only": 0 }, @@ -862,24 +864,11 @@ "print_hide": 1, "read_only": 0 }, - { - "amend": 0, - "cancel": 0, - "create": 0, - "doctype": "DocPerm", - "permlevel": 1, - "report": 0, - "role": "Sales Manager", - "submit": 0, - "write": 0 - }, { "amend": 1, "cancel": 1, "create": 1, "doctype": "DocPerm", - "permlevel": 0, - "report": 1, "role": "Sales Manager", "submit": 1, "write": 1 @@ -889,8 +878,6 @@ "cancel": 1, "create": 1, "doctype": "DocPerm", - "permlevel": 0, - "report": 1, "role": "Sales User", "submit": 1, "write": 1 @@ -900,19 +887,6 @@ "cancel": 0, "create": 0, "doctype": "DocPerm", - "permlevel": 1, - "report": 0, - "role": "Sales User", - "submit": 0, - "write": 0 - }, - { - "amend": 0, - "cancel": 0, - "create": 0, - "doctype": "DocPerm", - "permlevel": 0, - "report": 1, "role": "Customer", "submit": 0, "write": 0 @@ -922,43 +896,17 @@ "cancel": 1, "create": 1, "doctype": "DocPerm", - "permlevel": 0, - "report": 1, "role": "Maintenance Manager", "submit": 1, "write": 1 }, - { - "amend": 0, - "cancel": 0, - "create": 0, - "doctype": "DocPerm", - "permlevel": 1, - "report": 0, - "role": "Maintenance Manager", - "submit": 0, - "write": 0 - }, { "amend": 1, "cancel": 1, "create": 1, "doctype": "DocPerm", - "permlevel": 0, - "report": 1, "role": "Maintenance User", "submit": 1, "write": 1 - }, - { - "amend": 0, - "cancel": 0, - "create": 0, - "doctype": "DocPerm", - "permlevel": 1, - "report": 0, - "role": "Maintenance User", - "submit": 0, - "write": 0 } ] \ No newline at end of file From 0b9ec8cbc15afc96db99977fb17c81428056f3f6 Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Wed, 3 Apr 2013 13:45:28 +0530 Subject: [PATCH 2/2] [auto inventory accounting] [fix] if non stock item, dont create gl entry in delivery note and pos sales invoice --- accounts/doctype/sales_invoice/sales_invoice.py | 5 +++-- stock/doctype/delivery_note/delivery_note.py | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/accounts/doctype/sales_invoice/sales_invoice.py b/accounts/doctype/sales_invoice/sales_invoice.py index 9b17fc0e61..1003a8ec22 100644 --- a/accounts/doctype/sales_invoice/sales_invoice.py +++ b/accounts/doctype/sales_invoice/sales_invoice.py @@ -749,8 +749,9 @@ class DocType(SellingController): for item in self.doclist.get({"parentfield": "entries"}): self.check_expense_account(item) - gl_entries += self.get_gl_entries_for_stock(item.expense_account, - -1*item.buying_amount, cost_center=item.cost_center) + if item.buying_amount: + gl_entries += self.get_gl_entries_for_stock(item.expense_account, + -1*item.buying_amount, cost_center=item.cost_center) def make_pos_gl_entries(self, gl_entries): if cint(self.doc.is_pos) and self.doc.cash_bank_account and self.doc.paid_amount: diff --git a/stock/doctype/delivery_note/delivery_note.py b/stock/doctype/delivery_note/delivery_note.py index daf7d61519..ab7d060859 100644 --- a/stock/doctype/delivery_note/delivery_note.py +++ b/stock/doctype/delivery_note/delivery_note.py @@ -413,8 +413,9 @@ class DocType(SellingController): for item in self.doclist.get({"parentfield": "delivery_note_details"}): self.check_expense_account(item) - gl_entries += self.get_gl_entries_for_stock(item.expense_account, -1*item.buying_amount, - cost_center=item.cost_center) + if item.buying_amount: + gl_entries += self.get_gl_entries_for_stock(item.expense_account, -1*item.buying_amount, + cost_center=item.cost_center) if gl_entries: from accounts.general_ledger import make_gl_entries