Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Run income-tax-slab patch only if slab already exists in payroll period (#21684)

Browse Source
This commit is contained in:
Nabin Hait 2020-05-11 19:23:18 +05:30 committed by GitHub
parent e684727923
commit 85a89812a4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/patches/v13_0/move_tax_slabs_from_payroll_period_to_income_tax_slab.py
View File

@ -7,7 +7,7 @@ import frappe
from frappe.model.utils.rename_field import rename_field from frappe.model.utils.rename_field import rename_field
def execute(): def execute():
if not frappe.db.table_exists("Payroll Period"): if not (frappe.db.table_exists("Payroll Period") and frappe.db.table_exists("Taxable Salary Slab")):
return return
for doctype in ("income_tax_slab", "salary_structure_assignment", "employee_other_income", "income_tax_slab_other_charges"): for doctype in ("income_tax_slab", "salary_structure_assignment", "employee_other_income", "income_tax_slab_other_charges"):
@ -60,6 +60,9 @@ def execute():
""", (income_tax_slab.name, company.name, period.start_date)) """, (income_tax_slab.name, company.name, period.start_date))
# move other incomes to separate document # move other incomes to separate document
if not frappe.db.table_exists("Employee Tax Exemption Proof Submission"):
return
migrated = [] migrated = []
proofs = frappe.get_all("Employee Tax Exemption Proof Submission", proofs = frappe.get_all("Employee Tax Exemption Proof Submission",
filters = {'docstatus': 1}, filters = {'docstatus': 1},
@ -79,6 +82,9 @@ def execute():
except: except:
pass pass
if not frappe.db.table_exists("Employee Tax Exemption Declaration"):
return
declerations = frappe.get_all("Employee Tax Exemption Declaration", declerations = frappe.get_all("Employee Tax Exemption Declaration",
filters = {'docstatus': 1}, filters = {'docstatus': 1},
fields =['payroll_period', 'employee', 'company', 'income_from_other_sources'] fields =['payroll_period', 'employee', 'company', 'income_from_other_sources']