From 2f7cb82ca040e3bff433a11b2a2a4e28d802d7d0 Mon Sep 17 00:00:00 2001 From: Revant Nandgaonkar Date: Sat, 26 Aug 2017 09:58:15 +0530 Subject: [PATCH 1/3] [Fix] POS Scanner Search item based on key press instead of 1sec wait Fast Scanning needs this to avoid 1sec delay --- erpnext/accounts/page/pos/pos.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/erpnext/accounts/page/pos/pos.js b/erpnext/accounts/page/pos/pos.js index d69a306670..ee4644a51e 100644 --- a/erpnext/accounts/page/pos/pos.js +++ b/erpnext/accounts/page/pos/pos.js @@ -426,11 +426,11 @@ erpnext.pos.PointOfSale = erpnext.taxes_and_totals.extend({ }); this.serach_item.make_input(); - this.serach_item.$input.on("keyup", function () { - setTimeout(function () { + this.serach_item.$input.on("keypress", function (event) { + if((me.serach_item.$input.val() != "") && (event.which == 13)){ me.items = me.get_items(); me.make_item_list(); - }, 1000); + } }); this.search_item_group = this.wrapper.find('.search-item-group'); From 2558daf6b772c38c3e0a7393d506543ea9428ab5 Mon Sep 17 00:00:00 2001 From: Revant Nandgaonkar Date: Sat, 26 Aug 2017 15:52:35 +0530 Subject: [PATCH 2/3] Allow search without keypress enter --- erpnext/accounts/page/pos/pos.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/accounts/page/pos/pos.js b/erpnext/accounts/page/pos/pos.js index ee4644a51e..d576406ffc 100644 --- a/erpnext/accounts/page/pos/pos.js +++ b/erpnext/accounts/page/pos/pos.js @@ -427,7 +427,7 @@ erpnext.pos.PointOfSale = erpnext.taxes_and_totals.extend({ this.serach_item.make_input(); this.serach_item.$input.on("keypress", function (event) { - if((me.serach_item.$input.val() != "") && (event.which == 13)){ + if((me.serach_item.$input.val() != "") || (event.which == 13)){ me.items = me.get_items(); me.make_item_list(); } From 8fbc08f91f8f630a642fbfa6836cc7b8af3f3389 Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Mon, 28 Aug 2017 16:52:20 +0530 Subject: [PATCH 3/3] Decrease timeout to 400 --- erpnext/accounts/page/pos/pos.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/erpnext/accounts/page/pos/pos.js b/erpnext/accounts/page/pos/pos.js index d576406ffc..e362db0738 100644 --- a/erpnext/accounts/page/pos/pos.js +++ b/erpnext/accounts/page/pos/pos.js @@ -426,11 +426,16 @@ erpnext.pos.PointOfSale = erpnext.taxes_and_totals.extend({ }); this.serach_item.make_input(); + this.serach_item.$input.on("keypress", function (event) { - if((me.serach_item.$input.val() != "") || (event.which == 13)){ - me.items = me.get_items(); - me.make_item_list(); - } + + clearTimeout(me.last_search_timeout); + me.last_search_timeout = setTimeout(() => { + if((me.serach_item.$input.val() != "") || (event.which == 13)) { + me.items = me.get_items(); + me.make_item_list(); + } + }, 400); }); this.search_item_group = this.wrapper.find('.search-item-group');