From 840244c5628fe0a33dabff1bfc5bfda1e4963dea Mon Sep 17 00:00:00 2001 From: Rohit Waghchaure Date: Fri, 31 May 2019 12:16:35 +0530 Subject: [PATCH] fix: pricing rule is applying on the incorrect item --- erpnext/accounts/doctype/pricing_rule/utils.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/erpnext/accounts/doctype/pricing_rule/utils.py b/erpnext/accounts/doctype/pricing_rule/utils.py index d3db130f3a..8a8e3291aa 100644 --- a/erpnext/accounts/doctype/pricing_rule/utils.py +++ b/erpnext/accounts/doctype/pricing_rule/utils.py @@ -480,10 +480,10 @@ def apply_pricing_rule(doc, pr_doc, item_row, value, do_not_validate=False): rule_applied = {} for item in doc.get("items"): - if not item.pricing_rules: - item.pricing_rules = item_row.pricing_rules - if item.get(apply_on) in items: + if not item.pricing_rules: + item.pricing_rules = item_row.pricing_rules + for field in ['discount_percentage', 'discount_amount', 'rate']: if not pr_doc.get(field): continue