From 830b316543d3e71a316602b778dc857ef95364dd Mon Sep 17 00:00:00 2001 From: "Parth J. Kharwar" Date: Wed, 5 Feb 2020 15:01:13 +0530 Subject: [PATCH] fix: full day leaves not tagged as half day in attendance (#20487) * fix: full day leaves not tagged as half day in attendance * chore: code cleanup for half day date value set --- .../hr/doctype/leave_application/leave_application.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/erpnext/hr/doctype/leave_application/leave_application.js b/erpnext/hr/doctype/leave_application/leave_application.js index 14ffa0ed1f..1f50e27098 100755 --- a/erpnext/hr/doctype/leave_application/leave_application.js +++ b/erpnext/hr/doctype/leave_application/leave_application.js @@ -104,11 +104,16 @@ frappe.ui.form.on("Leave Application", { }, half_day: function(frm) { - if (frm.doc.from_date == frm.doc.to_date) { - frm.set_value("half_day_date", frm.doc.from_date); + if (frm.doc.half_day) { + if (frm.doc.from_date == frm.doc.to_date) { + frm.set_value("half_day_date", frm.doc.from_date); + } + else { + frm.trigger("half_day_datepicker"); + } } else { - frm.trigger("half_day_datepicker"); + frm.set_value("half_day_date", ""); } frm.trigger("calculate_total_days"); },