Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #23596 from marination/item-attribute-validation-on-non-template-item

Browse Source 
fix: Perform Item Attribute Value Validation on Variants Only
This commit is contained in:
rohitwaghchaure 2020-10-12 16:12:02 +05:30 committed by GitHub
commit 80519b1098
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
erpnext/stock/doctype/item_attribute/item_attribute.py
View File

@ -29,9 +29,18 @@ class ItemAttribute(Document):
'''Validate that if there are existing items with attributes, they are valid''' '''Validate that if there are existing items with attributes, they are valid'''
attributes_list = [d.attribute_value for d in self.item_attribute_values] attributes_list = [d.attribute_value for d in self.item_attribute_values]
for item in frappe.db.sql('''select i.name, iva.attribute_value as value # Get Item Variant Attribute details of variant items
from `tabItem Variant Attribute` iva, `tabItem` i where iva.attribute = %s items = frappe.db.sql("""
and iva.parent = i.name and i.has_variants = 0''', self.name, as_dict=1): select
i.name, iva.attribute_value as value
from
`tabItem Variant Attribute` iva, `tabItem` i
where
iva.attribute = %(attribute)s
and iva.parent = i.name and
i.variant_of is not null and i.variant_of != ''""", {"attribute" : self.name}, as_dict=1)
for item in items:
if self.numeric_values: if self.numeric_values:
validate_is_incremental(self, self.name, item.value, item.name) validate_is_incremental(self, self.name, item.value, item.name)
else: else: