From 7deaff1979be6b36822b452e2a8109826e6f7cd6 Mon Sep 17 00:00:00 2001 From: Anand Doshi Date: Wed, 13 Jun 2012 14:20:24 +0530 Subject: [PATCH] fixed default tax fetch issue --- erpnext/selling/doctype/sales_common/sales_common.js | 4 +++- erpnext/selling/doctype/sales_common/sales_common.py | 7 +++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/erpnext/selling/doctype/sales_common/sales_common.js b/erpnext/selling/doctype/sales_common/sales_common.js index 5e67c93df8..c852230ad4 100644 --- a/erpnext/selling/doctype/sales_common/sales_common.js +++ b/erpnext/selling/doctype/sales_common/sales_common.js @@ -30,7 +30,7 @@ cur_frm.cscript.load_taxes = function(doc, cdt, cdn, callback) { callback(doc, cdt, cdn); } } else { - $c_obj([doc],'load_default_taxes','',function(r,rt){ + $c_obj(make_doclist(doc.doctype, doc.name),'load_default_taxes','',function(r,rt){ refresh_field('other_charges'); if(callback) callback(doc, cdt, cdn); }); @@ -72,6 +72,8 @@ cur_frm.cscript.update_item_details = function(doc, dt, dn, callback) { cur_frm.cscript.load_defaults(doc, dt, dn, callback); } }); + } else { + cur_frm.cscript.load_taxes(doc, dt, dn, callback); } } diff --git a/erpnext/selling/doctype/sales_common/sales_common.py b/erpnext/selling/doctype/sales_common/sales_common.py index 62a6434fc1..f942a2f0f6 100644 --- a/erpnext/selling/doctype/sales_common/sales_common.py +++ b/erpnext/selling/doctype/sales_common/sales_common.py @@ -214,12 +214,15 @@ class DocType(TransactionBase): # Load Default Taxes # ==================== def load_default_taxes(self, obj): - self.get_other_charges(obj,1) + if cstr(obj.doc.charge): + self.get_other_charges(obj) + else: + self.get_other_charges(obj, 1) # Get other charges from Master # ================================================================================= - def get_other_charges(self,obj,default = 0): + def get_other_charges(self,obj, default=0): obj.doc.clear_table(obj.doclist,'other_charges') if not getlist(obj.doclist, 'other_charges'): if default: add_cond = 'ifnull(t2.is_default,0) = 1'