Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

dont validate items if item_code not found (#14344)

Browse Source 
item_code field is not set when created using invoice creation tool
This commit is contained in:
Zarrar 2018-06-05 10:32:09 +05:30 committed by Rushabh Mehta
parent 7cf01e7c75
commit 7c088ff623
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/controllers/buying_controller.py
View File

@ -467,7 +467,12 @@ class BuyingController(StockController):
def validate_item_type(doc, fieldname, message): def validate_item_type(doc, fieldname, message):
# iterate through items and check if they are valid sales or purchase items # iterate through items and check if they are valid sales or purchase items
items = [d.item_code for d in doc.items] items = [d.item_code for d in doc.items if d.item_code]
# No validation check inase of creating transaction using 'Opening Invoice Creation Tool'
if not items:
return
item_list = ", ".join(["'%s'" % frappe.db.escape(d) for d in items]) item_list = ", ".join(["'%s'" % frappe.db.escape(d) for d in items])
invalid_items = [d[0] for d in frappe.db.sql(""" invalid_items = [d[0] for d in frappe.db.sql("""