Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Make set_youtube_statistics reusable and job logic fix

Browse Source 
- Make sure job runs only once every hour
- set_youtube_statistics should be usable in and outside class
This commit is contained in:
marination 2020-09-10 16:42:20 +05:30
parent 71ac399369
commit 799d663398
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/utilities/doctype/video/video.py
View File

@ -21,7 +21,6 @@ class Video(Document):
if self.provider == "YouTube" and self.url and not self.get("youtube_video_id"): if self.provider == "YouTube" and self.url and not self.get("youtube_video_id"):
self.youtube_video_id = get_id_from_url(self.url) self.youtube_video_id = get_id_from_url(self.url)
@classmethod
def set_youtube_statistics(self, video_ids=None, update=True): def set_youtube_statistics(self, video_ids=None, update=True):
if self.provider == "YouTube" and not is_tracking_enabled(): if self.provider == "YouTube" and not is_tracking_enabled():
return return
@ -78,7 +77,8 @@ def update_youtube_data():
if frequency == 30: if frequency == 30:
batch_update_youtube_data() batch_update_youtube_data()
elif site_time.hour % frequency == 0: elif site_time.hour % frequency == 0 and site_time.minute < 15:
# make sure it runs within the first 15 mins of the hour
batch_update_youtube_data() batch_update_youtube_data()
@ -109,8 +109,8 @@ def get_id_from_url(url):
def batch_update_youtube_data(): def batch_update_youtube_data():
def prepare_and_set_data(video_list): def prepare_and_set_data(video_list):
video_ids = get_formatted_ids(video_list) video_ids = get_formatted_ids(video_list)
Video.provider = "YouTube" video_doc = frappe.new_doc("Video")
stats = Video.set_youtube_statistics(video_ids=video_ids, update=False) stats = video_doc.set_youtube_statistics(video_ids=video_ids, update=False)
set_youtube_data(stats) set_youtube_data(stats)
def set_youtube_data(entries): def set_youtube_data(entries):