Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ux): make "allow zero valuation rate" readonly if "s_warehouse" is set (#29681)

Browse Source 
* chore: make allow zero valuation rate readonly if s_warehouse is set

* fix: setting the checkbox to zero whenever the source warehouse is set

* fix: remove allow_on_submit and refresh trigger

Co-authored-by: Ankush Menat <ankush@frappe.io>
This commit is contained in:
Sagar Sharma 2022-02-26 11:25:02 +05:30 committed by GitHub
parent 71d33081aa
commit 77ffcd3aed
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/stock/doctype/stock_entry/stock_entry.js
View File

@ -629,6 +629,12 @@ frappe.ui.form.on('Stock Entry Detail', {
frm.events.set_serial_no(frm, cdt, cdn, () => { frm.events.set_serial_no(frm, cdt, cdn, () => {
frm.events.get_warehouse_details(frm, cdt, cdn); frm.events.get_warehouse_details(frm, cdt, cdn);
}); });
// set allow_zero_valuation_rate to 0 if s_warehouse is selected.
let item = frappe.get_doc(cdt, cdn);
if (item.s_warehouse) {
item.allow_zero_valuation_rate = 0;
}
}, },
t_warehouse: function(frm, cdt, cdn) { t_warehouse: function(frm, cdt, cdn) {

12
erpnext/stock/doctype/stock_entry_detail/stock_entry_detail.json
View File

@ -1,7 +1,7 @@
{ {
"actions": [], "actions": [],
"autoname": "hash", "autoname": "hash",
"creation": "2013-03-29 18:22:12", "creation": "2022-02-05 00:17:49.860824",
"doctype": "DocType", "doctype": "DocType",
"document_type": "Other", "document_type": "Other",
"editable_grid": 1, "editable_grid": 1,
@ -340,13 +340,13 @@
"label": "More Information" "label": "More Information"
}, },
{ {
"allow_on_submit": 1,
"default": "0", "default": "0",
"fieldname": "allow_zero_valuation_rate", "fieldname": "allow_zero_valuation_rate",
"fieldtype": "Check", "fieldtype": "Check",
"label": "Allow Zero Valuation Rate", "label": "Allow Zero Valuation Rate",
"no_copy": 1, "no_copy": 1,
"print_hide": 1 "print_hide": 1,
"read_only_depends_on": "eval:doc.s_warehouse"
}, },
{ {
"allow_on_submit": 1, "allow_on_submit": 1,
@ -556,12 +556,14 @@
"index_web_pages_for_search": 1, "index_web_pages_for_search": 1,
"istable": 1, "istable": 1,
"links": [], "links": [],
"modified": "2021-06-22 16:47:11.268975", "modified": "2022-02-26 00:51:24.963653",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Stock", "module": "Stock",
"name": "Stock Entry Detail", "name": "Stock Entry Detail",
"naming_rule": "Random",
"owner": "Administrator", "owner": "Administrator",
"permissions": [], "permissions": [],
"sort_field": "modified", "sort_field": "modified",
"sort_order": "ASC" "sort_order": "ASC",
"states": []
} }