Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: don't overwrite existing terms in transaction

Browse Source
This commit is contained in:
barredterra 2024-01-24 01:48:10 +01:00
parent 7a6a789199
commit 77b044f1a6
1 changed files with 26 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
erpnext/public/js/controllers/transaction.js
View File

@ -795,16 +795,34 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
me.frm.set_value("letter_head", company_doc.default_letter_head);
}
}
let selling_doctypes_for_tc = ["Sales Invoice", "Quotation", "Sales Order", "Delivery Note"];
if (company_doc.default_selling_terms && frappe.meta.has_field(me.frm.doc.doctype, "tc_name") &&
selling_doctypes_for_tc.indexOf(me.frm.doc.doctype) != -1) {
if (
company_doc.default_selling_terms &&
frappe.meta.has_field(me.frm.doc.doctype, "tc_name") &&
[
"Sales Invoice",
"Quotation",
"Sales Order",
"Delivery Note",
].includes(me.frm.doc.doctype) &&
!me.frm.doc.tc_name
) {
me.frm.set_value("tc_name", company_doc.default_selling_terms);
}
let buying_doctypes_for_tc = ["Request for Quotation", "Supplier Quotation", "Purchase Order",
"Material Request", "Purchase Receipt"];
// Purchase Invoice is excluded as per issue #3345
if (company_doc.default_buying_terms && frappe.meta.has_field(me.frm.doc.doctype, "tc_name") &&
buying_doctypes_for_tc.indexOf(me.frm.doc.doctype) != -1) {
if (
company_doc.default_buying_terms &&
frappe.meta.has_field(me.frm.doc.doctype, "tc_name") &&
[
"Request for Quotation",
"Supplier Quotation",
"Purchase Order",
// Purchase Invoice is excluded as per issue #3345
"Material Request",
"Purchase Receipt",
].includes(me.frm.doc.doctype) &&
!me.frm.doc.tc_name
) {
me.frm.set_value("tc_name", company_doc.default_buying_terms);
}