Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: call repost directly during tests (#30277)

Browse Source 
enqueue(now=frappe.flags.in_test) is always true in test, this change avoids
confusion.
This commit is contained in:
Ankush Menat 2022-03-16 19:50:56 +05:30 committed by GitHub
parent 2a0ca7c91a
commit 76187d175f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py
View File

@ -45,11 +45,21 @@ class RepostItemValuation(Document):
self.db_set('status', self.status) self.db_set('status', self.status)
def on_submit(self): def on_submit(self):
if not frappe.flags.in_test or self.flags.dont_run_in_test or frappe.flags.dont_execute_stock_reposts: """During tests reposts are executed immediately.
Exceptions:
1. "Repost Item Valuation" document has self.flags.dont_run_in_test
2. global flag frappe.flags.dont_execute_stock_reposts is set
These flags are useful for asserting real time behaviour like quantity updates.
"""
if not frappe.flags.in_test:
return
if self.flags.dont_run_in_test or frappe.flags.dont_execute_stock_reposts:
return return
frappe.enqueue(repost, timeout=1800, queue='long', repost(self)
job_name='repost_sle', now=frappe.flags.in_test, doc=self)
@frappe.whitelist() @frappe.whitelist()
def restart_reposting(self): def restart_reposting(self):