Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Autoname for customer and supplier (#27398)

Browse Source
This commit is contained in:
Deepesh Garg 2021-09-15 10:24:26 +05:30 committed by GitHub
parent 625626b973
commit 759f2b7920
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/buying/doctype/buying_settings/buying_settings.json
View File

@ -28,7 +28,7 @@
"fieldname": "supp_master_name", "fieldname": "supp_master_name",
"fieldtype": "Select", "fieldtype": "Select",
"label": "Supplier Naming By", "label": "Supplier Naming By",
"options": "Supplier Name\nNaming Series" "options": "Supplier Name\nNaming Series\nAuto Name"
}, },
{ {
"fieldname": "supplier_group", "fieldname": "supplier_group",
@ -123,7 +123,7 @@
"index_web_pages_for_search": 1, "index_web_pages_for_search": 1,
"issingle": 1, "issingle": 1,
"links": [], "links": [],
"modified": "2021-06-24 10:38:28.934525", "modified": "2021-09-08 19:26:23.548837",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Buying", "module": "Buying",
"name": "Buying Settings", "name": "Buying Settings",

6
erpnext/buying/doctype/supplier/supplier.py
View File

@ -10,7 +10,7 @@ from frappe.contacts.address_and_contact import (
delete_contact_and_address, delete_contact_and_address,
load_address_and_contact, load_address_and_contact,
) )
from frappe.model.naming import set_name_by_naming_series from frappe.model.naming import set_name_by_naming_series, set_name_from_naming_options
from erpnext.accounts.party import get_dashboard_info, validate_party_accounts from erpnext.accounts.party import get_dashboard_info, validate_party_accounts
from erpnext.utilities.transaction_base import TransactionBase from erpnext.utilities.transaction_base import TransactionBase
@ -40,8 +40,10 @@ class Supplier(TransactionBase):
supp_master_name = frappe.defaults.get_global_default('supp_master_name') supp_master_name = frappe.defaults.get_global_default('supp_master_name')
if supp_master_name == 'Supplier Name': if supp_master_name == 'Supplier Name':
self.name = self.supplier_name self.name = self.supplier_name
else: elif supp_master_name == 'Naming Series':
set_name_by_naming_series(self) set_name_by_naming_series(self)
else:
self.name = set_name_from_naming_options(frappe.get_meta(self.doctype).autoname, self)
def on_update(self): def on_update(self):
if not self.naming_series: if not self.naming_series:

6
erpnext/selling/doctype/customer/customer.py
View File

@ -14,7 +14,7 @@ from frappe.contacts.address_and_contact import (
) )
from frappe.desk.reportview import build_match_conditions, get_filters_cond from frappe.desk.reportview import build_match_conditions, get_filters_cond
from frappe.model.mapper import get_mapped_doc from frappe.model.mapper import get_mapped_doc
from frappe.model.naming import set_name_by_naming_series from frappe.model.naming import set_name_by_naming_series, set_name_from_naming_options
from frappe.model.rename_doc import update_linked_doctypes from frappe.model.rename_doc import update_linked_doctypes
from frappe.utils import cint, cstr, flt, get_formatted_email, today from frappe.utils import cint, cstr, flt, get_formatted_email, today
from frappe.utils.user import get_users_with_role from frappe.utils.user import get_users_with_role
@ -40,8 +40,10 @@ class Customer(TransactionBase):
cust_master_name = frappe.defaults.get_global_default('cust_master_name') cust_master_name = frappe.defaults.get_global_default('cust_master_name')
if cust_master_name == 'Customer Name': if cust_master_name == 'Customer Name':
self.name = self.get_customer_name() self.name = self.get_customer_name()
else: elif cust_master_name == 'Naming Series':
set_name_by_naming_series(self) set_name_by_naming_series(self)
else:
self.name = set_name_from_naming_options(frappe.get_meta(self.doctype).autoname, self)
def get_customer_name(self): def get_customer_name(self):

8
erpnext/selling/doctype/selling_settings/selling_settings.json
View File

@ -41,14 +41,14 @@
"fieldtype": "Select", "fieldtype": "Select",
"in_list_view": 1, "in_list_view": 1,
"label": "Customer Naming By", "label": "Customer Naming By",
"options": "Customer Name\nNaming Series" "options": "Customer Name\nNaming Series\nAuto Name"
}, },
{ {
"fieldname": "campaign_naming_by", "fieldname": "campaign_naming_by",
"fieldtype": "Select", "fieldtype": "Select",
"in_list_view": 1, "in_list_view": 1,
"label": "Campaign Naming By", "label": "Campaign Naming By",
"options": "Campaign Name\nNaming Series" "options": "Campaign Name\nNaming Series\nAuto Name"
}, },
{ {
"fieldname": "customer_group", "fieldname": "customer_group",
@ -204,7 +204,7 @@
"index_web_pages_for_search": 1, "index_web_pages_for_search": 1,
"issingle": 1, "issingle": 1,
"links": [], "links": [],
"modified": "2021-09-01 22:55:33.803624", "modified": "2021-09-08 19:38:10.175989",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Selling", "module": "Selling",
"name": "Selling Settings", "name": "Selling Settings",
@ -223,4 +223,4 @@
"sort_field": "modified", "sort_field": "modified",
"sort_order": "DESC", "sort_order": "DESC",
"track_changes": 1 "track_changes": 1
} }