Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Add validation for GST Settings

Browse Source
This commit is contained in:
Deepesh Garg 2021-05-02 18:22:29 +05:30
parent f6610c96dd
commit 72e602ae54
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
erpnext/regional/doctype/gst_settings/gst_settings.py
View File

@ -19,6 +19,21 @@ class GSTSettings(Document):
from tabAddress where country = "India" and ifnull(gstin, '')!='' ''') from tabAddress where country = "India" and ifnull(gstin, '')!='' ''')
self.set_onload('data', data) self.set_onload('data', data)
def validate(self):
# Validate duplicate accounts
self.validate_duplicate_accounts()
def validate_duplicate_accounts(self):
account_list = []
for account in self.get('gst_accounts'):
for fieldname in ['cgst_account', 'sgst_account', 'igst_account', 'cess_account']:
if account.get(fieldname) in account_list:
frappe.throw(_("Account {0} appears multiple times").format(
frappe.bold(account.get(fieldname))))
if account.get(fieldname):
account_list.append(account.get(fieldname))
@frappe.whitelist() @frappe.whitelist()
def send_reminder(): def send_reminder():
frappe.has_permission('GST Settings', throw=True) frappe.has_permission('GST Settings', throw=True)