diff --git a/erpnext/accounts/doctype/pricing_rule/pricing_rule.py b/erpnext/accounts/doctype/pricing_rule/pricing_rule.py index b4fe148916..f298bc88f9 100644 --- a/erpnext/accounts/doctype/pricing_rule/pricing_rule.py +++ b/erpnext/accounts/doctype/pricing_rule/pricing_rule.py @@ -165,6 +165,13 @@ def get_pricing_rule_for_item(args): }) else: item_details.discount_percentage = pricing_rule.discount_percentage + elif args.get('pricing_rule'): + if frappe.db.get_value('Pricing Rule', args.get('pricing_rule'), 'price_or_discount') == 'Discount Percentage': + item_details.discount_percentage = 0.0 + + item_details.margin_rate_or_amount = 0.0 + item_details.margin_type = None + return item_details def get_pricing_rules(args): diff --git a/erpnext/patches/v7_0/rename_salary_components.py b/erpnext/patches/v7_0/rename_salary_components.py index ecf2faf34a..4e9ceb2173 100644 --- a/erpnext/patches/v7_0/rename_salary_components.py +++ b/erpnext/patches/v7_0/rename_salary_components.py @@ -78,9 +78,12 @@ def execute(): for doctype, cols in dt_cols_de.items(): source_cols = "`" + "`, `".join(standard_cols_de + cols) + "`" - - frappe.db.sql("""INSERT INTO `tabSalary Component` ({0}) SELECT {1} FROM `tab{2}`""" - .format(target_cols, source_cols, doctype)) + try: + frappe.db.sql("""INSERT INTO `tabSalary Component` ({0}) SELECT {1} FROM `tab{2}`""" + .format(target_cols, source_cols, doctype)) + except Exception, e: + if e.args[0]==1062: + pass update_customizations() diff --git a/erpnext/public/js/controllers/taxes_and_totals.js b/erpnext/public/js/controllers/taxes_and_totals.js index f642da1f64..aeceda4982 100644 --- a/erpnext/public/js/controllers/taxes_and_totals.js +++ b/erpnext/public/js/controllers/taxes_and_totals.js @@ -4,10 +4,6 @@ erpnext.taxes_and_totals = erpnext.payments.extend({ setup: function() {}, apply_pricing_rule_on_item: function(item){ - if(!item.margin_type){ - item.margin_rate_or_amount = 0.0; - } - if(item.margin_type == "Percentage"){ item.total_margin = item.price_list_rate + item.price_list_rate * ( item.margin_rate_or_amount / 100); }else{ diff --git a/erpnext/public/js/controllers/transaction.js b/erpnext/public/js/controllers/transaction.js index 0244cf31ca..aa20e79e07 100644 --- a/erpnext/public/js/controllers/transaction.js +++ b/erpnext/public/js/controllers/transaction.js @@ -710,7 +710,8 @@ erpnext.TransactionController = erpnext.taxes_and_totals.extend({ "brand": d.brand, "qty": d.qty, "parenttype": d.parenttype, - "parent": d.parent + "parent": d.parent, + "pricing_rule": d.pricing_rule }); // if doctype is Quotation Item / Sales Order Iten then add Margin Type and rate in item_list