Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: discard empty rows from update items (#27021)

Browse Source
This commit is contained in:
Ankush Menat 2021-08-24 12:18:40 +05:30 committed by GitHub
parent 0dff0beaba
commit 6de7b8ea93
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/controllers/accounts_controller.py
View File

@ -1836,6 +1836,11 @@ def update_child_qty_rate(parent_doctype, trans_items, parent_doctype_name, chil
for d in data: for d in data:
new_child_flag = False new_child_flag = False
if not d.get("item_code"):
# ignore empty rows
continue
if not d.get("docname"): if not d.get("docname"):
new_child_flag = True new_child_flag = True
check_doc_permissions(parent, 'create') check_doc_permissions(parent, 'create')

2
erpnext/public/js/utils.js
View File

@ -563,7 +563,7 @@ erpnext.utils.update_child_items = function(opts) {
}, },
], ],
primary_action: function() { primary_action: function() {
const trans_items = this.get_values()["trans_items"]; const trans_items = this.get_values()["trans_items"].filter((item) => !!item.item_code);
frappe.call({ frappe.call({
method: 'erpnext.controllers.accounts_controller.update_child_qty_rate', method: 'erpnext.controllers.accounts_controller.update_child_qty_rate',
freeze: true, freeze: true,