Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: unnecessary variables

Browse Source
This commit is contained in:
Rucha Mahabal 2021-07-07 09:43:28 +05:30
parent ad06603392
commit 6d5ee25bba
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
erpnext/public/js/hierarchy_chart/hierarchy_chart_desktop.js
View File

@ -153,7 +153,7 @@ erpnext.HierarchyChart = class {
} }
expand_node(node) { expand_node(node) {
let is_sibling = this.selected_node && this.selected_node.parent_id === node.parent_id; const is_sibling = this.selected_node && this.selected_node.parent_id === node.parent_id;
this.set_selected_node(node); this.set_selected_node(node);
this.show_active_path(node); this.show_active_path(node);
this.collapse_previous_level_nodes(node); this.collapse_previous_level_nodes(node);
@ -243,11 +243,9 @@ erpnext.HierarchyChart = class {
} }
add_node(node, data) { add_node(node, data) {
var $li = $('<li class="child-node"></li>');
return new this.Node({ return new this.Node({
id: data.id, id: data.id,
parent: $li.appendTo(node.$children), parent: $('<li class="child-node"></li>').appendTo(node.$children),
parent_id: node.id, parent_id: node.id,
image: data.image, image: data.image,
name: data.name, name: data.name,
@ -259,8 +257,8 @@ erpnext.HierarchyChart = class {
} }
add_connector(parent_id, child_id) { add_connector(parent_id, child_id) {
let parent_node = document.querySelector(`#${parent_id}`); const parent_node = document.querySelector(`#${parent_id}`);
let child_node = document.querySelector(`#${child_id}`); const child_node = document.querySelector(`#${child_id}`);
let path = document.createElementNS('http://www.w3.org/2000/svg', 'path'); let path = document.createElementNS('http://www.w3.org/2000/svg', 'path');
@ -276,7 +274,7 @@ erpnext.HierarchyChart = class {
let connector = this.get_connector(pos_parent_right, pos_child_left); let connector = this.get_connector(pos_parent_right, pos_child_left);
path.setAttribute("d", connector); path.setAttribute('d', connector);
this.set_path_attributes(path, parent_id, child_id); this.set_path_attributes(path, parent_id, child_id);
$('#connectors').append(path); $('#connectors').append(path);
@ -385,7 +383,7 @@ erpnext.HierarchyChart = class {
let node_element = $(`#${node.id}`); let node_element = $(`#${node.id}`);
node_element.click(function() { node_element.click(function() {
let is_sibling = me.selected_node.parent_id === node.parent_id; const is_sibling = me.selected_node.parent_id === node.parent_id;
if (is_sibling) { if (is_sibling) {
me.collapse_node(); me.collapse_node();