From 6d313c72e1793c1863be18570c2ae9108b455b32 Mon Sep 17 00:00:00 2001 From: deepeshgarg007 Date: Sat, 1 Jun 2019 23:26:42 +0530 Subject: [PATCH] fix: Remove diemnsion from value list if present --- .../doctype/accounting_dimension/accounting_dimension.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py b/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py index 931b479720..91d03be493 100644 --- a/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py +++ b/erpnext/accounts/doctype/accounting_dimension/accounting_dimension.py @@ -108,7 +108,9 @@ def delete_accounting_dimension(doc): budget_against_property = frappe.get_doc("Property Setter", "Budget-budget_against-options") value_list = budget_against_property.value.split('\n')[3:] - value_list.remove(doc.document_type) + + if doc.document_type in value_list: + value_list.remove(doc.document_type) budget_against_property.value = "\nCost Center\nProject\n" + "\n".join(value_list) budget_against_property.save()