Minor bugfix (#15210)

* Minor bugfix

Bugfix for https://github.com/frappe/erpnext/pull/15170

* Update project.py
This commit is contained in:
Benji 2018-09-05 15:54:53 +08:00 committed by Nabin Hait
parent 5122a8e0d7
commit 6c9a92671b

View File

@ -86,7 +86,7 @@ class Project(Document):
def validate_weights(self):
for task in self.tasks:
if task.task_weight is not None:
if task.task_weight > 0:
if task.task_weight < 0:
frappe.throw(_("Task weight cannot be negative"))
def sync_tasks(self):
@ -208,7 +208,7 @@ class Project(Document):
project=%s""", self.name, as_dict=1)
pct_complete = 0
for row in weighted_progress:
pct_complete += row["progress"] * row["task_weight"] / weight_sum
pct_complete += row["progress"] * frappe.utils.safe_div(row["task_weight"], weight_sum)
self.percent_complete = flt(flt(pct_complete), 2)
if self.percent_complete == 100:
self.status = "Completed"