Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: provision to setup new address from lead if address creation break due to mandatory exception

Browse Source
This commit is contained in:
Saurabh 2020-03-09 11:57:47 +05:30
parent e567563aa1
commit 6c8d63f3b9
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
erpnext/crm/doctype/lead/lead.py
View File

@ -137,10 +137,13 @@ class Lead(SellingController):
# skipping country since the system auto-sets it from system defaults # skipping country since the system auto-sets it from system defaults
address = frappe.new_doc("Address") address = frappe.new_doc("Address")
mandatory_fields = get_mandatory_fields(address) mandatory_fields = [ df.fieldname for df in doc.meta.fields if df.reqd ]
if not all([self.get(field) for field in mandatory_fields]): if not all([self.get(field) for field in mandatory_fields]):
frappe.msgprint(_('Missing mandatory fields in address.'), alert=True, indicator='yellow') frappe.msgprint(_('Missing mandatory fields in address. \
{0} to create address' ).format("<a href='desk#Form/Address/New Address 1' \
> Click here </a>"),
alert=True, indicator='yellow')
return return
address.update({addr_field: self.get(addr_field) for addr_field in address_fields}) address.update({addr_field: self.get(addr_field) for addr_field in address_fields})
@ -374,10 +377,3 @@ def get_lead_with_phone_number(number):
lead = leads[0].name if leads else None lead = leads[0].name if leads else None
return lead return lead
def get_mandatory_fields(doc):
return [
df.fieldname
for df in doc.meta.fields
if df.reqd
]