Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Codacy corrections

Browse Source
This commit is contained in:
Charles-Henri Decultot 2018-05-24 07:23:18 +00:00
parent a27673ecfe
commit 6c2ad66522
8 changed files with 6 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/erpnext_integrations/doctype/payment_plan/payment_plan.js
View File

@ -2,7 +2,5 @@
// For license information, please see license.txt // For license information, please see license.txt
frappe.ui.form.on('Payment Plan', { frappe.ui.form.on('Payment Plan', {
refresh: function(frm) {
}
}); });

1
erpnext/erpnext_integrations/doctype/payment_plan/payment_plan.py
View File

@ -3,7 +3,6 @@
# For license information, please see license.txt # For license information, please see license.txt
from __future__ import unicode_literals from __future__ import unicode_literals
import frappe
from frappe.model.document import Document from frappe.model.document import Document
class PaymentPlan(Document): class PaymentPlan(Document):

1
erpnext/erpnext_integrations/doctype/payment_plan/test_payment_plan.py
View File

@ -3,7 +3,6 @@
# See license.txt # See license.txt
from __future__ import unicode_literals from __future__ import unicode_literals
import frappe
import unittest import unittest
class TestPaymentPlan(unittest.TestCase): class TestPaymentPlan(unittest.TestCase):

2
erpnext/erpnext_integrations/doctype/stripe_settings/stripe_settings.js
View File

@ -2,7 +2,5 @@
// For license information, please see license.txt // For license information, please see license.txt
frappe.ui.form.on('Stripe Settings', { frappe.ui.form.on('Stripe Settings', {
refresh: function(frm) {
}
}); });

10
erpnext/erpnext_integrations/doctype/stripe_settings/stripe_settings.py
View File

@ -8,7 +8,7 @@ from frappe.model.document import Document
from frappe import _ from frappe import _
from six.moves.urllib.parse import urlencode from six.moves.urllib.parse import urlencode
from frappe.utils import get_url, call_hook_method, cint, flt from frappe.utils import get_url, call_hook_method, cint, flt
from frappe.integrations.utils import make_get_request, make_post_request, create_request_log, create_payment_gateway from frappe.integrations.utils import make_get_request, create_request_log, create_payment_gateway
import stripe import stripe
class StripeSettings(Document): class StripeSettings(Document):
@ -88,10 +88,8 @@ class StripeSettings(Document):
else: else:
frappe.log_error(charge.failure_message, 'Stripe Payment not completed') frappe.log_error(charge.failure_message, 'Stripe Payment not completed')
except: except Exception:
frappe.log_error(frappe.get_traceback()) frappe.log_error(frappe.get_traceback())
# failed
pass
return self.finalize_request() return self.finalize_request()
@ -114,11 +112,9 @@ class StripeSettings(Document):
self.integration_request.db_set('status', 'Failed', update_modified=False) self.integration_request.db_set('status', 'Failed', update_modified=False)
frappe.log_error('Subscription N°: ' + subscription.id, 'Stripe Payment not completed') frappe.log_error('Subscription N°: ' + subscription.id, 'Stripe Payment not completed')
except: except Exception:
self.integration_request.db_set('status', 'Failed', update_modified=False) self.integration_request.db_set('status', 'Failed', update_modified=False)
frappe.log_error(frappe.get_traceback()) frappe.log_error(frappe.get_traceback())
# failed
pass
return self.finalize_request() return self.finalize_request()

1
erpnext/erpnext_integrations/doctype/stripe_settings/test_stripe_settings.py
View File

@ -3,7 +3,6 @@
# See license.txt # See license.txt
from __future__ import unicode_literals from __future__ import unicode_literals
import frappe
import unittest import unittest
class TestStripeSettings(unittest.TestCase): class TestStripeSettings(unittest.TestCase):

2
erpnext/templates/pages/integrations/stripe_checkout.css
View File

@ -18,7 +18,7 @@
} }
.StripeElement--webkit-autofill { .StripeElement--webkit-autofill {
background-color: #fefde5 !important; background-color: #fefde5;
} }
.stripe #payment-form { .stripe #payment-form {

2
erpnext/templates/pages/integrations/stripe_checkout.py
View File

@ -3,7 +3,7 @@
from __future__ import unicode_literals from __future__ import unicode_literals
import frappe import frappe
from frappe import _ from frappe import _
from frappe.utils import flt, cint, fmt_money from frappe.utils import cint, fmt_money
import json import json
from erpnext.erpnext_integrations.doctype.stripe_settings.stripe_settings import get_gateway_controller from erpnext.erpnext_integrations.doctype.stripe_settings.stripe_settings import get_gateway_controller