Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #35410 from rohitwaghchaure/fixed-negative-reserved-qty-for-production-plan

Browse Source 
fix: Negative value in Reserved Qty for Production Plan
This commit is contained in:
rohitwaghchaure 2023-05-24 19:08:14 +05:30 committed by GitHub
commit 693133d8f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/manufacturing/doctype/production_plan/production_plan.py
View File

@ -1534,7 +1534,7 @@ def get_reserved_qty_for_production_plan(item_code, warehouse):
frappe.qb.from_(table) frappe.qb.from_(table)
.inner_join(child) .inner_join(child)
.on(table.name == child.parent) .on(table.name == child.parent)
.select(Sum(child.quantity * IfNull(child.conversion_factor, 1.0))) .select(Sum(child.required_bom_qty * IfNull(child.conversion_factor, 1.0)))
.where( .where(
(table.docstatus == 1) (table.docstatus == 1)
& (child.item_code == item_code) & (child.item_code == item_code)
@ -1552,6 +1552,9 @@ def get_reserved_qty_for_production_plan(item_code, warehouse):
get_reserved_qty_for_production(item_code, warehouse, check_production_plan=True) get_reserved_qty_for_production(item_code, warehouse, check_production_plan=True)
) )
if reserved_qty_for_production > reserved_qty_for_production_plan:
return 0.0
return reserved_qty_for_production_plan - reserved_qty_for_production return reserved_qty_for_production_plan - reserved_qty_for_production