Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Add test for loan repayment cancellation

Browse Source
This commit is contained in:
Deepesh Garg 2021-12-28 18:10:52 +05:30
parent f78bf4c6ef
commit 68d49817a1
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/loan_management/doctype/loan/test_loan.py
View File

@ -218,6 +218,14 @@ class TestLoan(unittest.TestCase):
self.assertEqual(flt(loan.total_principal_paid, 0), flt(repayment_entry.amount_paid -
penalty_amount - total_interest_paid, 0))
# Check Repayment Entry cancel
repayment_entry.load_from_db()
repayment_entry.cancel()
loan.load_from_db()
self.assertEqual(loan.total_principal_paid, 0)
self.assertEqual(loan.total_principal_paid, 0)
def test_loan_closure(self):
pledge = [{
"loan_security": "Test Security 1",

2
erpnext/loan_management/doctype/loan_repayment/loan_repayment.py
View File

@ -134,7 +134,7 @@ class LoanRepayment(AccountsController):
})
pending_principal_amount = get_pending_principal_amount(loan)
if not loan.is_secured_loan and pending_principal_amount < 0:
if not loan.is_secured_loan and pending_principal_amount <= 0:
loan.update({'status': 'Loan Closure Requested'})
for payment in self.repayment_details: