From 683a89a4159db7d1d500fe5b86196ac55d70fcfd Mon Sep 17 00:00:00 2001 From: deepeshgarg007 Date: Sat, 12 Oct 2019 23:02:53 +0530 Subject: [PATCH] fix: Chart fix in Analytics report --- erpnext/selling/report/sales_analytics/sales_analytics.js | 6 +++++- erpnext/selling/report/sales_analytics/sales_analytics.py | 6 ++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/erpnext/selling/report/sales_analytics/sales_analytics.js b/erpnext/selling/report/sales_analytics/sales_analytics.js index 149c923d5c..80874c1deb 100644 --- a/erpnext/selling/report/sales_analytics/sales_analytics.js +++ b/erpnext/selling/report/sales_analytics/sales_analytics.js @@ -80,10 +80,14 @@ frappe.query_reports["Sales Analytics"] = { var tree_type = frappe.query_report.filters[0].value; - if(tree_type == "Customer" || tree_type == "Item") { + if(tree_type == "Customer") { row_values = data.slice(4,length-1).map(function (column) { return column.content; }) + } else if (tree_type == "Item") { + row_values = data.slice(5,length-1).map(function (column) { + return column.content; + }) } else { row_values = data.slice(3,length-1).map(function (column) { diff --git a/erpnext/selling/report/sales_analytics/sales_analytics.py b/erpnext/selling/report/sales_analytics/sales_analytics.py index 72767f0689..f1726ab8bf 100644 --- a/erpnext/selling/report/sales_analytics/sales_analytics.py +++ b/erpnext/selling/report/sales_analytics/sales_analytics.py @@ -136,7 +136,7 @@ class Analytics(object): if self.filters["value_quantity"] == 'Value': value_field = 'base_amount' else: - value_field = 'qty' + value_field = 'stock_qty' self.entries = frappe.db.sql(""" select i.item_code as entity, i.item_name as entity_name, i.stock_uom, i.{value_field} as value_field, s.{date_field} @@ -338,8 +338,10 @@ class Analytics(object): def get_chart_data(self): length = len(self.columns) - if self.filters.tree_type in ["Customer", "Supplier", "Item"]: + if self.filters.tree_type in ["Customer", "Supplier"]: labels = [d.get("label") for d in self.columns[2:length - 1]] + elif self.filters.tree_type == "Item": + labels = [d.get("label") for d in self.columns[3:length - 1]] else: labels = [d.get("label") for d in self.columns[1:length - 1]] self.chart = {