Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: shopping cart quotation without website item

Browse Source
This commit is contained in:
Devin Slauenwhite 2021-12-30 13:06:52 -05:00 committed by marination
parent e088e65871
commit 678a1179d4
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/selling/doctype/quotation/quotation.py
View File

@ -27,6 +27,7 @@ class Quotation(SellingController):
self.set_status() self.set_status()
self.validate_uom_is_integer("stock_uom", "qty") self.validate_uom_is_integer("stock_uom", "qty")
self.validate_valid_till() self.validate_valid_till()
self.validate_shopping_cart_items()
self.set_customer_name() self.set_customer_name()
if self.items: if self.items:
self.with_items = 1 self.with_items = 1
@ -49,6 +50,13 @@ class Quotation(SellingController):
if self.valid_till and getdate(self.valid_till) < getdate(self.transaction_date): if self.valid_till and getdate(self.valid_till) < getdate(self.transaction_date):
frappe.throw(_("Valid till date cannot be before transaction date")) frappe.throw(_("Valid till date cannot be before transaction date"))
def validate_shopping_cart_items(self):
if self.order_type != "Shopping Cart": return
for item in self.items:
if not frappe.db.exists("Website Item", {"item_code": item.item_code}):
frappe.throw(_("Item {0} must be a website item for Shopping Cart quotations".format(item.item_code)))
def has_sales_order(self): def has_sales_order(self):
return frappe.db.get_value("Sales Order Item", {"prevdoc_docname": self.name, "docstatus": 1}) return frappe.db.get_value("Sales Order Item", {"prevdoc_docname": self.name, "docstatus": 1})