Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update stock_ageing.py

Browse Source 
As reviewer Deepesh Garg advised thanks!  batch[0] can be int of float - see line 49 - so change proposed cint to flt
This commit is contained in:
John Clarke 2020-06-12 05:53:24 -06:00 committed by GitHub
parent 6b55f66f02
commit 677978dd00
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/stock/report/stock_ageing/stock_ageing.py
View File

@ -180,14 +180,14 @@ def get_fifo_queue(filters, sle=None):
qty_to_pop = abs(d.actual_qty) qty_to_pop = abs(d.actual_qty)
while qty_to_pop: while qty_to_pop:
batch = fifo_queue[0] if fifo_queue else [0, None] batch = fifo_queue[0] if fifo_queue else [0, None]
if 0 < cint(batch[0]) <= qty_to_pop: if 0 < flt(batch[0]) <= qty_to_pop:
# if batch qty > 0 # if batch qty > 0
# not enough or exactly same qty in current batch, clear batch # not enough or exactly same qty in current batch, clear batch
qty_to_pop -= cint(batch[0]) qty_to_pop -= flt(batch[0])
transferred_item_details[(d.voucher_no, d.name)].append(fifo_queue.pop(0)) transferred_item_details[(d.voucher_no, d.name)].append(fifo_queue.pop(0))
else: else:
# all from current batch # all from current batch
cint(batch[0]) -= qty_to_pop flt(batch[0]) -= qty_to_pop
transferred_item_details[(d.voucher_no, d.name)].append([qty_to_pop, batch[1]]) transferred_item_details[(d.voucher_no, d.name)].append([qty_to_pop, batch[1]])
qty_to_pop = 0 qty_to_pop = 0