Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: failing tests

Browse Source
This commit is contained in:
Saqib Ansari 2021-12-02 15:54:02 +05:30
parent a1cedc3ea0
commit 6736a89b4e
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/support/doctype/service_level_agreement/service_level_agreement.py
View File

@ -409,7 +409,7 @@ def handle_status_change(doc, prev_status, apply_sla_for_resolution):
if is_open_status(prev_status) and not is_open_status(doc.status): if is_open_status(prev_status) and not is_open_status(doc.status):
# status changed from Open to something else # status changed from Open to something else
if doc.meta.has_field("first_responded_on") and not doc.first_responded_on: if doc.meta.has_field("first_responded_on") and not doc.get('first_responded_on'):
doc.first_responded_on = now_time doc.first_responded_on = now_time
# Open to Replied # Open to Replied
@ -760,18 +760,18 @@ def update_agreement_status(doc, apply_sla_for_resolution):
if (doc.meta.has_field("agreement_status")): if (doc.meta.has_field("agreement_status")):
# if SLA is applied for resolution check for response and resolution, else only response # if SLA is applied for resolution check for response and resolution, else only response
if apply_sla_for_resolution: if apply_sla_for_resolution:
if doc.meta.has_field("first_responded_on") and not doc.first_responded_on: if doc.meta.has_field("first_responded_on") and not doc.get('first_responded_on'):
doc.agreement_status = "First Response Due" doc.agreement_status = "First Response Due"
elif not doc.resolution_date: elif doc.meta.has_field("resolution_date") and not doc.get('resolution_date'):
doc.agreement_status = "Resolution Due" doc.agreement_status = "Resolution Due"
elif get_datetime(doc.resolution_date) <= get_datetime(doc.resolution_by): elif get_datetime(doc.get('resolution_date')) <= get_datetime(doc.get('resolution_by')):
doc.agreement_status = "Fulfilled" doc.agreement_status = "Fulfilled"
else: else:
doc.agreement_status = "Failed" doc.agreement_status = "Failed"
else: else:
if doc.meta.has_field("first_responded_on") and not doc.first_responded_on: if doc.meta.has_field("first_responded_on") and not doc.get('first_responded_on'):
doc.agreement_status = "First Response Due" doc.agreement_status = "First Response Due"
elif get_datetime(doc.first_responded_on) <= get_datetime(doc.response_by): elif get_datetime(doc.get('first_responded_on')) <= get_datetime(doc.get('response_by')):
doc.agreement_status = "Fulfilled" doc.agreement_status = "Fulfilled"
else: else:
doc.agreement_status = "Failed" doc.agreement_status = "Failed"