Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[fix] [validation] website url should be public

Browse Source
This commit is contained in:
Anand Doshi 2015-12-11 15:02:58 +05:30
parent 4a9f6ba520
commit 66c9940d73
1 changed files with 21 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
erpnext/stock/doctype/item/item.py
View File

@ -89,24 +89,30 @@ class Item(WebsiteGenerator):
auto_set_website_image = True auto_set_website_image = True
self.website_image = self.image self.website_image = self.image
if self.website_image: if not self.website_image:
file = frappe.db.get_value("File", filters={ return
"file_url": self.website_image,
"attached_to_doctype": self.doctype, # find if website image url exists as public
"attached_to_name": self.name file = frappe.get_all("File", filters={
}, fieldname=["name", "is_private"], as_dict=True) "file_url": self.website_image
}, fields=["name", "is_private"], order_by="is_private asc", limit_poge_length=1)
if file:
file = file[0]
if not file: if not file:
if not auto_set_website_image: if not auto_set_website_image:
frappe.msgprint(_("Website Image {0} attached to Item {1} cannot be found") frappe.msgprint(_("Website Image {0} attached to Item {1} cannot be found")
.format(self.website_image, self.name)) .format(self.website_image, self.name))
self.website_image = None self.website_image = None
elif file.is_private: elif file.is_private:
self.website_image = None
if not auto_set_website_image: if not auto_set_website_image:
frappe.msgprint(_("Website Image should be a public file or website URL")) frappe.msgprint(_("Website Image should be a public file or website URL"))
self.website_image = None
def make_thumbnail(self): def make_thumbnail(self):
"""Make a thumbnail of `website_image`""" """Make a thumbnail of `website_image`"""
import requests.exceptions import requests.exceptions