Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(validate): Qty is mandatory in delivery note

Browse Source
This commit is contained in:
Anurag mishra 2018-11-26 11:28:22 +05:30 committed by Anurag Mishra
parent bc4574b59d
commit 66bd5810c5
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/stock/doctype/delivery_note/delivery_note.py
View File

@ -98,6 +98,7 @@ class DeliveryNote(SellingController):
frappe.throw(_("Sales Order required for Item {0}").format(d.item_code)) frappe.throw(_("Sales Order required for Item {0}").format(d.item_code))
def validate(self): def validate(self):
self.validate_qty()
self.validate_posting_time() self.validate_posting_time()
super(DeliveryNote, self).validate() super(DeliveryNote, self).validate()
self.set_status() self.set_status()
@ -121,9 +122,8 @@ class DeliveryNote(SellingController):
if not self.installation_status: self.installation_status = 'Not Installed' if not self.installation_status: self.installation_status = 'Not Installed'
def validate_qty(self): def validate_qty(self):
data = frappe.get_all("Delivery Note Item", filters={"parent" : self.name}, fields=["qty"]) for item in self.items:
for quant in data: if not item.qty:
if quant.qty == 0:
frappe.throw("Item quantity can not be zero") frappe.throw("Item quantity can not be zero")
def validate_with_previous_doc(self): def validate_with_previous_doc(self):