From 667f0fbd6def1e8ed5deb9ffc090457b210f8e5a Mon Sep 17 00:00:00 2001 From: patilsangram Date: Thu, 8 Nov 2018 12:51:41 +0530 Subject: [PATCH] [fix] Invoice/Delivery note customer po_no overwritten by Sales order null po_no (#15785) --- erpnext/controllers/selling_controller.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/erpnext/controllers/selling_controller.py b/erpnext/controllers/selling_controller.py index 57c6556a03..719f4c732a 100644 --- a/erpnext/controllers/selling_controller.py +++ b/erpnext/controllers/selling_controller.py @@ -345,7 +345,8 @@ class SellingController(StockController): sales_orders = list(set([d.get(ref_fieldname) for d in self.items if d.get(ref_fieldname)])) if sales_orders: po_nos = frappe.get_all('Sales Order', 'po_no', filters = {'name': ('in', sales_orders)}) - self.po_no = ', '.join(list(set([d.po_no for d in po_nos if d.po_no]))) + if po_nos and po_nos[0].get('po_no'): + self.po_no = ', '.join(list(set([d.po_no for d in po_nos if d.po_no]))) def validate_items(self): # validate items to see if they have is_sales_item enabled