Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(tests): account and company setups

Browse Source
This commit is contained in:
Rucha Mahabal 2022-06-01 17:28:42 +05:30
parent 1c91793634
commit 661e05e693
1 changed files with 18 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
erpnext/payroll/doctype/payroll_entry/test_payroll_entry.py
View File

@ -86,44 +86,32 @@ class TestPayrollEntry(FrappeTestCase):
) )
def test_multi_currency_payroll_entry(self): def test_multi_currency_payroll_entry(self):
company = erpnext.get_default_company() company = frappe.get_doc("Company", "_Test Company")
employee = make_employee("test_muti_currency_employee@payroll.com", company=company) employee = make_employee(
for data in frappe.get_all("Salary Component", fields=["name"]): "test_muti_currency_employee@payroll.com", company=company.name, department="Accounts - _TC"
if not frappe.db.get_value( )
"Salary Component Account", {"parent": data.name, "company": company}, "name" salary_structure = "_Test Multi Currency Salary Structure"
): setup_salary_structure(employee, company, "USD", salary_structure)
get_salary_component_account(data.name)
company_doc = frappe.get_doc("Company", company)
salary_structure = make_salary_structure(
"_Test Multi Currency Salary Structure", "Monthly", company=company, currency="USD"
)
create_salary_structure_assignment(
employee, salary_structure.name, company=company, currency="USD"
)
frappe.db.sql(
"""delete from `tabSalary Slip` where employee=%s""",
(frappe.db.get_value("Employee", {"user_id": "test_muti_currency_employee@payroll.com"})),
)
salary_slip = get_salary_slip(
"test_muti_currency_employee@payroll.com", "Monthly", "_Test Multi Currency Salary Structure"
)
dates = get_start_end_dates("Monthly", nowdate()) dates = get_start_end_dates("Monthly", nowdate())
payroll_entry = make_payroll_entry( payroll_entry = make_payroll_entry(
start_date=dates.start_date, start_date=dates.start_date,
end_date=dates.end_date, end_date=dates.end_date,
payable_account=company_doc.default_payroll_payable_account, payable_account=company.default_payroll_payable_account,
currency="USD", currency="USD",
exchange_rate=70, exchange_rate=70,
company=company.name,
cost_center="Main - _TC",
) )
payroll_entry.make_payment_entry() payroll_entry.make_payment_entry()
salary_slip.load_from_db() salary_slip = frappe.db.get_value("Salary Slip", {"payroll_entry": payroll_entry.name}, "name")
salary_slip = frappe.get_doc("Salary Slip", salary_slip)
payroll_entry.reload()
payroll_je = salary_slip.journal_entry payroll_je = salary_slip.journal_entry
if payroll_je: if payroll_je:
payroll_je_doc = frappe.get_doc("Journal Entry", payroll_je) payroll_je_doc = frappe.get_doc("Journal Entry", payroll_je)
self.assertEqual(salary_slip.base_gross_pay, payroll_je_doc.total_debit) self.assertEqual(salary_slip.base_gross_pay, payroll_je_doc.total_debit)
self.assertEqual(salary_slip.base_gross_pay, payroll_je_doc.total_credit) self.assertEqual(salary_slip.base_gross_pay, payroll_je_doc.total_credit)
@ -136,7 +124,6 @@ class TestPayrollEntry(FrappeTestCase):
(payroll_entry.name), (payroll_entry.name),
as_dict=1, as_dict=1,
) )
self.assertEqual(salary_slip.base_net_pay, payment_entry[0].total_debit) self.assertEqual(salary_slip.base_net_pay, payment_entry[0].total_debit)
self.assertEqual(salary_slip.base_net_pay, payment_entry[0].total_credit) self.assertEqual(salary_slip.base_net_pay, payment_entry[0].total_credit)
@ -306,7 +293,7 @@ class TestPayrollEntry(FrappeTestCase):
def test_salary_slip_operation_queueing(self): def test_salary_slip_operation_queueing(self):
company = "_Test Company" company = "_Test Company"
company_doc = frappe.get_doc("Company", company) company_doc = frappe.get_doc("Company", company)
employee = frappe.db.get_value("Employee", {"company": company}) employee = make_employee("test_employee@payroll.com", company=company)
setup_salary_structure(employee, company_doc) setup_salary_structure(employee, company_doc)
# enqueue salary slip creation via payroll entry # enqueue salary slip creation via payroll entry
@ -318,6 +305,7 @@ class TestPayrollEntry(FrappeTestCase):
payable_account=company_doc.default_payroll_payable_account, payable_account=company_doc.default_payroll_payable_account,
currency=company_doc.default_currency, currency=company_doc.default_currency,
company=company_doc.name, company=company_doc.name,
cost_center="Main - _TC",
) )
frappe.flags.enqueue_payroll_entry = True frappe.flags.enqueue_payroll_entry = True
payroll_entry.create_salary_slips() payroll_entry.create_salary_slips()
@ -329,7 +317,7 @@ class TestPayrollEntry(FrappeTestCase):
def test_salary_slip_operation_failure(self): def test_salary_slip_operation_failure(self):
company = "_Test Company" company = "_Test Company"
company_doc = frappe.get_doc("Company", company) company_doc = frappe.get_doc("Company", company)
employee = frappe.db.get_value("Employee", {"company": company}) employee = make_employee("test_employee@payroll.com", company=company)
salary_structure = make_salary_structure( salary_structure = make_salary_structure(
"_Test Salary Structure", "_Test Salary Structure",
@ -353,6 +341,7 @@ class TestPayrollEntry(FrappeTestCase):
payable_account=company_doc.default_payroll_payable_account, payable_account=company_doc.default_payroll_payable_account,
currency=company_doc.default_currency, currency=company_doc.default_currency,
company=company_doc.name, company=company_doc.name,
cost_center="Main - _TC",
) )
payroll_entry.create_salary_slips() payroll_entry.create_salary_slips()
payroll_entry.submit_salary_slips() payroll_entry.submit_salary_slips()
@ -375,7 +364,7 @@ class TestPayrollEntry(FrappeTestCase):
def test_payroll_entry_status(self): def test_payroll_entry_status(self):
company = "_Test Company" company = "_Test Company"
company_doc = frappe.get_doc("Company", company) company_doc = frappe.get_doc("Company", company)
employee = frappe.db.get_value("Employee", {"company": company}) employee = make_employee("test_employee@payroll.com", company=company)
setup_salary_structure(employee, company_doc) setup_salary_structure(employee, company_doc)
@ -386,6 +375,7 @@ class TestPayrollEntry(FrappeTestCase):
payable_account=company_doc.default_payroll_payable_account, payable_account=company_doc.default_payroll_payable_account,
currency=company_doc.default_currency, currency=company_doc.default_currency,
company=company_doc.name, company=company_doc.name,
cost_center="Main - _TC",
) )
payroll_entry.submit() payroll_entry.submit()
self.assertEqual(payroll_entry.status, "Submitted") self.assertEqual(payroll_entry.status, "Submitted")
@ -466,15 +456,6 @@ def make_holiday(holiday_list_name):
return holiday_list_name return holiday_list_name
def get_salary_slip(user, period, salary_structure):
salary_slip = make_employee_salary_slip(user, period, salary_structure)
salary_slip.exchange_rate = 70
salary_slip.calculate_net_pay()
salary_slip.db_update()
return salary_slip
def setup_salary_structure(employee, company_doc, currency=None, salary_structure=None): def setup_salary_structure(employee, company_doc, currency=None, salary_structure=None):
for data in frappe.get_all("Salary Component", pluck="name"): for data in frappe.get_all("Salary Component", pluck="name"):
if not frappe.db.get_value( if not frappe.db.get_value(