From 6575e52942156a1b2dceaaf435fc1c61da7f34b6 Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Sun, 30 Sep 2018 21:08:46 +0530 Subject: [PATCH] fix: Refactor Review Area according to new Text Editor (#15536) - depends on https://github.com/frappe/frappe/pull/6159 --- .../public/js/hub/components/CommentInput.vue | 5 +- .../public/js/hub/components/ReviewArea.vue | 81 ++++++++++++++++--- 2 files changed, 75 insertions(+), 11 deletions(-) diff --git a/erpnext/public/js/hub/components/CommentInput.vue b/erpnext/public/js/hub/components/CommentInput.vue index cc430d0c28..31562c7a28 100644 --- a/erpnext/public/js/hub/components/CommentInput.vue +++ b/erpnext/public/js/hub/components/CommentInput.vue @@ -18,18 +18,19 @@ export default { }, methods: { make_input() { - this.message_input = new frappe.ui.CommentArea({ + this.message_input = frappe.ui.form.make_control({ parent: this.$refs['comment-input'], on_submit: (message) => { this.message_input.reset(); this.$emit('change', message); }, + only_input: true, no_wrapper: true }); }, submit_input() { if (!this.message_input) return; - const value = this.message_input.val(); + const value = this.message_input.get_value(); if (!value) return; this.message_input.submit(); } diff --git a/erpnext/public/js/hub/components/ReviewArea.vue b/erpnext/public/js/hub/components/ReviewArea.vue index 159fdd112f..51b9ab1502 100644 --- a/erpnext/public/js/hub/components/ReviewArea.vue +++ b/erpnext/public/js/hub/components/ReviewArea.vue @@ -1,6 +1,44 @@