Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: sider and semgrep

Browse Source
This commit is contained in:
marination 2021-06-21 16:51:12 +05:30
parent 9ac9a4ef21
commit 654e9d85d1
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
erpnext/controllers/stock_controller.py
View File

@ -387,11 +387,11 @@ class StockController(AccountsController):
def validate_qi_presence(self, row): def validate_qi_presence(self, row):
"""Check if QI is present on row level. Warn on save and stop on submit if missing.""" """Check if QI is present on row level. Warn on save and stop on submit if missing."""
if not row.quality_inspection: if not row.quality_inspection:
msg = _(f"Row #{row.idx}: Quality Inspection is required for Item {frappe.bold(row.item_code)}") msg = f"Row #{row.idx}: Quality Inspection is required for Item {frappe.bold(row.item_code)}"
if self.docstatus == 1: if self.docstatus == 1:
frappe.throw(msg, title=_("Inspection Required"), exc=QualityInspectionRequiredError) frappe.throw(_(msg), title=_("Inspection Required"), exc=QualityInspectionRequiredError)
else: else:
frappe.msgprint(msg, title=_("Inspection Required"), indicator="blue") frappe.msgprint(_(msg), title=_("Inspection Required"), indicator="blue")
def validate_qi_submission(self, row): def validate_qi_submission(self, row):
"""Check if QI is submitted on row level, during submission""" """Check if QI is submitted on row level, during submission"""
@ -400,11 +400,11 @@ class StockController(AccountsController):
if not qa_docstatus == 1: if not qa_docstatus == 1:
link = frappe.utils.get_link_to_form('Quality Inspection', row.quality_inspection) link = frappe.utils.get_link_to_form('Quality Inspection', row.quality_inspection)
msg = _(f"Row #{row.idx}: Quality Inspection {link} is not submitted for the item: {row.item_code}") msg = f"Row #{row.idx}: Quality Inspection {link} is not submitted for the item: {row.item_code}"
if action == "Stop": if action == "Stop":
frappe.throw(msg, title=_("Inspection Submission"), exc=QualityInspectionNotSubmittedError) frappe.throw(_(msg), title=_("Inspection Submission"), exc=QualityInspectionNotSubmittedError)
else: else:
frappe.msgprint(msg, alert=True) frappe.msgprint(_(msg), alert=True)
def validate_qi_rejection(self, row): def validate_qi_rejection(self, row):
"""Check if QI is rejected on row level, during submission""" """Check if QI is rejected on row level, during submission"""
@ -413,11 +413,11 @@ class StockController(AccountsController):
if qa_status == "Rejected": if qa_status == "Rejected":
link = frappe.utils.get_link_to_form('Quality Inspection', row.quality_inspection) link = frappe.utils.get_link_to_form('Quality Inspection', row.quality_inspection)
msg = _(f"Row #{row.idx}: Quality Inspection was rejected for item {row.item_code}") msg = f"Row #{row.idx}: Quality Inspection {link} was rejected for item {row.item_code}"
if action == "Stop": if action == "Stop":
frappe.throw(msg, title=_("Inspection Rejected"), exc=QualityInspectionRejectedError) frappe.throw(_(msg), title=_("Inspection Rejected"), exc=QualityInspectionRejectedError)
else: else:
frappe.msgprint(msg, alert=True, indicator="orange") frappe.msgprint(_(msg), alert=True, indicator="orange")
def update_blanket_order(self): def update_blanket_order(self):
blanket_orders = list(set([d.blanket_order for d in self.items if d.blanket_order])) blanket_orders = list(set([d.blanket_order for d in self.items if d.blanket_order]))