From 62d58acea98a1a4b31bfd1b20dd2b5411a622386 Mon Sep 17 00:00:00 2001 From: Anurag Mishra <32095923+Anurag810@users.noreply.github.com> Date: Thu, 30 May 2019 14:04:08 +0530 Subject: [PATCH] fix: Added description if item variants does not have description in map(v12) (#17796) * fix: variant item description based on attribute * style: removed unwanted changes --- erpnext/controllers/item_variant.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/erpnext/controllers/item_variant.py b/erpnext/controllers/item_variant.py index 631f7751b4..bfb8432cab 100644 --- a/erpnext/controllers/item_variant.py +++ b/erpnext/controllers/item_variant.py @@ -279,14 +279,14 @@ def copy_attributes_to_variant(item, variant): variant.set(field.fieldname, item.get(field.fieldname)) variant.variant_of = item.name - if 'description' in allow_fields: - variant.has_variants = 0 + + if 'description' not in allow_fields: if not variant.description: variant.description = "" if item.variant_based_on=='Item Attribute': if variant.attributes: - attributes_description = "" + attributes_description = item.description + " " for d in variant.attributes: attributes_description += "
" + d.attribute + ": " + cstr(d.attribute_value) + "
"